1. Hey guyz. Welcome to the All New Phlatforum!



    Sign Up and take a look around. There are so many awesome new features.

    The Phlatforum is a place we can all hang out and

    have fun sharing our RC adventures!

  2. Dismiss Notice
Welcome to The Phlatforum PhlatPrinter III

Logical problem in PhlatMill.rb in rare conditions

Discussion in 'SketchUcam Bugs' started by ahd71, Jan 30, 2012.

  1. ahd71

    ahd71 New Member

    Offline
    Messages:
    8
    Trophy Points:
    1
    I found a typo in the PhlatMill.rb (file version 656 in SVN; script version 664)

    I believe the following code section...

    [pre] command_out += (format_measure('X', xo)) if (xo != @cx)
    command_out += (format_measure('Y', yo)) if (yo != @cx)
    command_out += (format_measure('Z', zo)) if (zo != @cx)

    ...should have been....

    command_out += (format_measure('X', xo)) if (xo != @cx)
    command_out += (format_measure('Y', yo)) if (yo != @cy)
    command_out += (format_measure('Z', zo)) if (zo != @cz)
    [/pre]

    ...in order to not skip Y and Z values if they happend to be the same as X value.

    BR/ahd71
     
    ahd71, Jan 30, 2012
    #1
  2. TigerPilot

    TigerPilot Well-Known Member

    Offline
    Messages:
    1,578
    Trophy Points:
    48
    Come on, ahd71, help a dummy. Where is the difference between the two. Been looking at it for few minutes and can't find it.
     
    TigerPilot, Jan 30, 2012
    #2
  3. 3DMON

    3DMON Moderator Staff Member

    Offline
    Messages:
    2,380
    Trophy Points:
    38
    Location:
    Sebastian, Florida
    The very end of the code. cx, cx, cx was corrected to cx, cy, cz

    Good find ahd71
     
    3DMON, Jan 30, 2012
    #3
  4. kram242

    kram242 Administrator Staff Member

    Offline
    Messages:
    6,311
    Trophy Points:
    13
    Location:
    NJ
    Nice find ahd71, thank you for sharing this it will be updated on the next release
    Mark and Trish
     
    kram242, Jan 30, 2012
    #4

Share This Page